-
Notifications
You must be signed in to change notification settings - Fork 54
WIP move to ruimarinho images + other changes #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
willcl-ark
merged 28 commits into
bitcoin-dev-project:main
from
willcl-ark:ruimarinho-images
Sep 6, 2023
Merged
WIP move to ruimarinho images + other changes #90
willcl-ark
merged 28 commits into
bitcoin-dev-project:main
from
willcl-ark:ruimarinho-images
Sep 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives more flexibility thatn Typer, can now run `warcli rpc 1 -netinfo 4` which was a pain in Typer...
|
The annoying thing about ruimarinho images is they are 2 versions out of date :'( But I plan to host our own warnet images (with tor and the other bits we want pre-installed), so can easily-enough make our own v24.1 and v25.0 images at that time I think... |
* better code organisation * persist running scenarios to disk for later restore
takes ages to format large logs
f9d24ee to
7276fcd
Compare
|
I've opened ruimarinho/docker-bitcoin-core#144 to try and fixup that repo, so we can use it here :) |
243dccc to
38b8364
Compare
We can keep these better maintained, and they work just as well
38b8364 to
7e1416a
Compare
output was being doubled by print() statements in calling functions
|
Now includes some @pinheadmz fixups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love to see some testing on this from others, if possible, i'd recommend something like:
Then README.md should guide you through the process :)
I plan to